Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-31951)[API] fix: Event products can only be of type SEANCE_CINE #14235

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mageoffray
Copy link
Contributor

@mageoffray mageoffray commented Sep 19, 2024

But de la pull request

Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-31951

Have tests and sandbox that represent the real life.
Here is what we have in staging :

select count(*), "subcategoryId" from product group by "subcategoryId";
+---------+---------------------------------+
| count   | subcategoryId                   |
|---------+---------------------------------|
| 3231009 | LIVRE_PAPIER                    |
| 4990    | SEANCE_CINE                     |
| 747365  | SUPPORT_PHYSIQUE_MUSIQUE_CD     |
| 200750  | SUPPORT_PHYSIQUE_MUSIQUE_VINYLE |
+---------+---------------------------------+

I'll do another PR that will change the OfferFactory : if an offer is linked to a product, the subcategory, name, extraData and other fields should come from the product

Vérifications

  • J'ai écrit les tests nécessaires
  • J'ai mis à jour le fichier des plans de tests du portail pro si nécessaire
  • J'ai mis à jour la liste des routes et des titres de pages du portail pro si j'en ai rajouté/modifié ou supprimé une.
  • J'ai relu attentivement les migrations, en particulier pour éviter les locks, et je préviens les équipes Shérif et Data
  • J'ai ajouté des screenshots pour d'éventuels changements graphiques

@mageoffray mageoffray force-pushed the mageoffray/PC-31951-have-a-real-offer-with-product branch 3 times, most recently from 67080a2 to b9d1840 Compare September 19, 2024 15:22
@mageoffray mageoffray force-pushed the mageoffray/PC-31951-have-a-real-offer-with-product branch from b9d1840 to 1829011 Compare September 20, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants